Reloque

Fresh install of the 6.x branch, in a Windows 7 environment. I always mess something up by step (9), because I got an error while updating the world database (see below, the error was the same). I tried again with a fresh MySQL instance (in case I messed something else up), but this time I stepped through the world updates manually (!) instead of using a merged SQL. I backed everything up after applying 2015_03_30_02_world.sql, then tried 2015_03_30_03_world.sql a couple times again. The error is always the same: C:Program FilesMySQLMySQL Server 5.6bin>mysql --default-character-set=utf8 --max_allowed_packet=10000000 -u root -p world < "C:SoftwareTrinityCore6sqlupdatesworld2015_03_30_03_world.sql" Enter password: ********** ERROR 1054 (42S22) at line 54: Unknown column 'Probability0' in 'field list' At this point I reverted to 2015_03_30_02_world.sql and looked at line 54 of 2015_03_30_03_world.sql myself. 2015_03_30_03_world.sql expects the table "npc-text" to contain the column "Probability0", but when I examined my database it contained "prob0". So I visited GitHub and found this to be the product of retroactive changes rather than an original error. Without walking through code, I couldn't determine whether to fix the 2015_03_30_03_world.sql or my database. So I did look at the other updates, and in 2015_04_11_00_world.sql the column is renamed from "prob0" to "Probability0". It appears* that the correct thing to do is fix 2015_03_30_03_world.sql. (pretty much the same thing with "Probability1") If a SQL update doesn't work (as it probably was, and is now) it makes sense to change it. But otherwise, is it safe to change SQLs which have already been committed? This particular commit changed thirteen world database updates which other people may have already applied to their databases (I only had problems with 2015_03_30_03_world.sql). *I successfully applied all of the updates after fixing 2015_03_30_03_world.sql. As a side note, it would be nice if there was more specific mention of the hotfixes SQL distributed in the TBD. The wiki is particularly bad about this: if you follow the wiki to the letter you will end up trying to apply updates to an empty hotfixes database!