Jump to content
TrinityCore

Spp

Members
  • Content Count

    65
  • Joined

  • Last visited

  • Days Won

    7

Spp last won the day on June 24 2014

Spp had the most liked content!

Community Reputation

34 Excellent

About Spp

  • Rank
    Advanced Member

Profile Information

  • Gender
    Not Telling

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. Fixed: https://github.com/TrinityCore/TrinityCore/commit/51287930cb147cace9308713d0affddbf38df4d8
  2. Log is clear: "Unknown column 'type' in 'field list'" You miss some sql updates, core crash because the database is not up to date.
  3. Click: as we talked on IRC all the changes i introduced to cmake files were done by another dev i trust and i just pushed to TC. Forwarded your text to him and this is his answer (it's a copy&paste of his words) Cmake provides OpenSLL macro, but got it reverted as Shaured said cmake uses the first library it finds even if it's x86 when compiling x64 Reason of change: Did not include support for OS X-specific features and did not retrieve all compile flags, so PCH were build with options not compatible with sources and were not used at all during compilation. Will do further tests, change was done without thinking ccache / distcc Wrong. -ggdb produce debug information in GDB-specific format, it is not a right format on all platforms. (also GDB3 does not exists for more than 20 years, 3.1 release was done in 1989) -g3 produces the most possible debug info. "-g Produce debugging information in the operating system's native format (stabs, COFF, XCOFF, or DWARF 2). GDB can work with this debugging information. On most systems that use stabs format, -g enables use of extra debugging information that only GDB can use; this extra information makes debugging work better in GDB but probably makes other debuggers crash or refuse to read the program. If you want to control for certain whether to generate the extra information, use -gstabs+, -gstabs, -gxcoff+, -gxcoff, or -gvms (see below)." So g3 will enable most (if not all) extensions that are enabled by ggdb if native debug format is the same. Official docs are here: http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html#Debugging-Options Sure, I'm fucking it up and use it on everyday basis as my primary development OS is UNIX-like xcode is an IDE, code was changed to support clang (compiler). To specific suppor for xcode something like this should be added if(MSVC) message(FATAL_ERROR "Your compiler is not supported. Consider using GCC or Clang.") endif() if("${CMAKE_GENERATOR}" MATCHES "Xcode") set(GLOBAL_XCODE_PROPERTIES XCODE_ATTRIBUTE_CLANG_CXX_LANGUAGE_STANDARD "gnu++0x" XCODE_ATTRIBUTE_CLANG_CXX_LIBRARY "libc++" XCODE_ATTRIBUTE_CLANG_LINK_OBJC_RUNTIME NO XCODE_ATTRIBUTE_CLANG_WARN_IMPLICIT_SIGN_CONVERSION NO XCODE_ATTRIBUTE_CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION NO XCODE_ATTRIBUTE_CLANG_WARN__EXIT_TIME_DESTRUCTORS NO XCODE_ATTRIBUTE_GCC_C_LANGUAGE_STANDARD "gnu99" XCODE_ATTRIBUTE_GCC_ENABLE_OBJC_EXCEPTIONS NO XCODE_ATTRIBUTE_GCC_INLINES_ARE_PRIVATE_EXTERN YES XCODE_ATTRIBUTE_GCC_STRICT_ALIASING YES XCODE_ATTRIBUTE_GCC_SYMBOLS_PRIVATE_EXTERN YES XCODE_ATTRIBUTE_GCC_TREAT_INCOMPATIBLE_POINTER_TYPE_WARNINGS_AS_ERRORS YES XCODE_ATTRIBUTE_GCC_WARN_64_TO_32_BIT_CONVERSION NO XCODE_ATTRIBUTE_GCC_WARN_ABOUT_MISSING_NEWLINE YES XCODE_ATTRIBUTE_GCC_WARN_ABOUT_RETURN_TYPE YES XCODE_ATTRIBUTE_GCC_WARN_FOUR_CHARACTER_CONSTANTS YES XCODE_ATTRIBUTE_GCC_WARN_HIDDEN_VIRTUAL_FUNCTIONS YES XCODE_ATTRIBUTE_GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED YES XCODE_ATTRIBUTE_GCC_WARN_NON_VIRTUAL_DESTRUCTOR YES XCODE_ATTRIBUTE_GCC_WARN_PEDANTIC YES XCODE_ATTRIBUTE_GCC_WARN_SHADOW YES XCODE_ATTRIBUTE_GCC_WARN_SIGN_COMPARE YES XCODE_ATTRIBUTE_GCC_WARN_UNINITIALIZED_AUTOS YES XCODE_ATTRIBUTE_GCC_WARN_UNUSED_PARAMETER YES XCODE_ATTRIBUTE_GCC_WARN_UNUSED_VARIABLE YES XCODE_ATTRIBUTE_WARNING_CFLAGS "-Wall -Wextra" ) if(NOT DEFINED OVERRIDE_DONE) set(OVERRIDE_DONE 1) function(add_executable TARGET) _add_executable(${TARGET} ${ARGN}) set_target_properties(${TARGET} PROPERTIES ${GLOBAL_XCODE_PROPERTIES}) endfunction() function(add_library TARGET) _add_library(${TARGET} ${ARGN}) set_target_properties(${TARGET} PROPERTIES ${GLOBAL_XCODE_PROPERTIES}) endfunction() endif() else() set(CMAKE_BUILD_TYPE_INIT "Debug") set(FLAGS_C "-fvisibility=hidden -pedantic -W -Wall -Wextra -Wno-missing-field-initializers") set(FLAGS_CXX "${FLAGS_C} -fvisibility-inlines-hidden") if("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU") set(CMAKE_C_FLAGS_INIT "-std=gnu99 ${FLAGS_C} ${CMAKE_C_FLAGS_INIT}") set(CMAKE_CXX_FLAGS_INIT "-std=gnu++11 ${FLAGS_CXX} ${CMAKE_CXX_FLAGS_INIT}") elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang") set(CMAKE_C_FLAGS_INIT "-std=gnu99 ${FLAGS_C} ${CMAKE_C_FLAGS_INIT}") set(CMAKE_CXX_FLAGS_INIT "-std=gnu++11 -stdlib=libc++ ${FLAGS_CXX} ${CMAKE_CXX_FLAGS_INIT}") endif() endif() Not required if program is correct. Will provide an example as soon as I rebott to mac, brb. template<class T> void FleeingMovementGenerator<T>::_setTargetLocation(T &owner) { if (!&owner) return; For example this code in trinity repo. Something is passed by reference and reference can not be NULL (in case some specific mumbo-jumbo is not done). With -fno-delete-no-pointer-checks compiler has to produce code for this check, though it is useless in 99% of cases. In fact I remember only one discussion when NULL pointer check was wrongly removed in Linux kernel sources, I doubt that it is ever required in userspace program.
×
×
  • Create New...