McAdams Posted January 20, 2021 Report Share Posted January 20, 2021 I'm building master for the first time and noticed that the required client version is listed in the repo description text. This text isn't tied to history though - a different client version is required for the last tag in master, and we can't see the repo description text at the time that tag was created. I'd like to be able to build even further back in time, as I have even older client versions. Is there a place in the source code where the required client version is defined? Link to comment Share on other sites More sharing options...
McAdams Posted January 21, 2021 Author Report Share Posted January 21, 2021 After digging around in the code, it looks like the best match for this is /sql/base/auth_database.sql - this has a list of client build numbers. Will jump around in history and see what shakes. Link to comment Share on other sites More sharing options...
Shauren Posted January 21, 2021 Report Share Posted January 21, 2021 Generally only major patches get tagged with git tags (on their last commit, before update to the next one), minor hotfix builds do not - your best bet is to look at commit history Link to comment Share on other sites More sharing options...
McAdams Posted January 21, 2021 Author Report Share Posted January 21, 2021 Thanks Shauren. I have a 35662 client, but I built off an official 37176 client using the current head (as of 2021-02-20). My in-client realm lists the available realm as "Incompatible". Tried fudging the "gamebuild" field in realm_list, which I know has no guarantees of working, and it didn't. Using the history on auth_database.sql I'm guessing building @ https://github.com/TrinityCore/TrinityCore/commit/87448621acd28990ea0fdd600a665012b27d5d98#diff-9548ad5730e018dba61771500dfc778592a20e2bc587d475f7669ed2be7cfc66 when 35662 was added might get me in. Am I way off base? Link to comment Share on other sites More sharing options...
Aokromes Posted January 22, 2021 Report Share Posted January 22, 2021 11 hours ago, McAdams said: Thanks Shauren. I have a 35662 client, but I built off an official 37176 client using the current head (as of 2021-02-20). My in-client realm lists the available realm as "Incompatible". Tried fudging the "gamebuild" field in realm_list, which I know has no guarantees of working, and it didn't. Using the history on auth_database.sql I'm guessing building @ https://github.com/TrinityCore/TrinityCore/commit/87448621acd28990ea0fdd600a665012b27d5d98#diff-9548ad5730e018dba61771500dfc778592a20e2bc587d475f7669ed2be7cfc66 when 35662 was added might get me in. Am I way off base? just update your client to retail version. Link to comment Share on other sites More sharing options...
Shauren Posted January 22, 2021 Report Share Posted January 22, 2021 But that builld DOES have a git tag... https://github.com/TrinityCore/TrinityCore/tree/8.3.7/35662 Link to comment Share on other sites More sharing options...
Recommended Posts