Jump to content
Why are these forums read only? ×
TrinityCore
Why are these forums read only?

click

Members
 View Profile  See their activity

  • Posts

    142

  • Joined

  • Last visited

  • Days Won

    8

 Content Type 

Posts posted by click

  1. REST-on-the-SOAP - We want help from YOU!

    in Releases and Announcements

    Posted

    Hi everyone!

    We're looking for new developers to assist with enhancing TrinityCore with proper SOAP/REST-based webservice-support - there's no pay, but a lot of glory!

    People that wants to get involved will get :
    *) a free copy of the TrinityCore sourcecode (available on GitHub, all yours for the picking!)
    *) opportunities to swear at the other devs in our IRC developers-channel (who doesn't want to do this?)

    *) lots of gray hair (unless hairless, like me)

    *) your code inside one of the most fun codebases to work on

     

    What we're aiming for:

    *) To actually start using the gSoap-library we've got in the sourcetree for something else than just being a mediator between executeCommand and prettified XML output.

    *) Exposing more functions to the public than is currently done - we have _1_ (one) function active per today - we're really awesome-sauce aren't we?

     

    Some minor, but important, requirements:

    *) You need to know how to code in C++.

    *) You need to understand how SOAP/REST works.

    *) You need to have a keen eye for details to avoid doing the same funny/silly/scary/whatever mistakes that the rest of us do all the time... :D
     

    If YOU want to assist in creating this, please give us a note here on the forums, or on IRC for those of you wandering by there!
     

    we-want-you-stellenanzeige.jpg

    • Upvote 3

  2. Compile or cmake problems

    in Help and Support

    Posted 

    diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5335207..f01b21e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -13,7 +13,11 @@ project(TrinityCore)

 # CMake policies (can not be handled elsewhere)
 cmake_minimum_required(VERSION 2.8)
-cmake_policy(SET CMP0005 OLD)
+
+# add this options before PROJECT keyword
+set(CMAKE_DISABLE_SOURCE_CHANGES ON)
+set(CMAKE_DISABLE_IN_SOURCE_BUILD ON)
+

 # Set RPATH-handing (CMake parameters)
 set(CMAKE_SKIP_BUILD_RPATH 0)

    That SHOULD make the error occur on 2.8.x, and thus verify my theory on the subject.

  3. Compile or cmake problems

    in Help and Support

    Posted

    +Spp :

    Do you have any specific reasoning behind removing the cmake macro for OpenSSL-handling?

     

    And, why are you rewriting the PCH-system?

     

    PCH-headers including the .cpp header into a predefined object (gch-file) adds another useless file for gcc-based compilations, and the earlier version worked totally fine.

     

    This ALSO destroys clusterbased compilation, since the gch-file is NEVER propagated to the external host systems. Which means that IF my buildbotsystem would use the PCH-system, it would fuck up, as the GCH-file is local, and not propagated to the cluster-compilers. This would then add load to the LOCAL system on a massive amount each time something was/is/will be pushed into the repository.

     

    All you would have needed to do would be to add the correct testcase for clang, and adjust the macro accordingly - it has worked flawless for years.

     

    Now, to the main issue : why the HELL are you removing GCC-specific compileflags allowing debugging to be done properly under GDB3?

    This is not something that you or anyone else should nilly-willy do without discussing it here first.

    Some info:

     

    -ggdb : Produce debugging information for use by GDB. This means to use the most expressive format available (DWARF 2, stabs, or the native format if neither of those are supported), including GDB extensions if at all possible.

     

    vs

     

    -g3 : Level 3 includes extra information, such as all the macro definitions present in the program. Some debuggers support macro expansion when you use -g3.

     

    These two are NOT EQUAL, and removes specific GDB3-tagging in the binary - basically, you're fucking up gdb debugging, which is the standard debugger for *nix-based platforms

    If clang fails using it, tough luck, define it different for clang through the cmake/compiler/* definitions per compiler, and EXPLICITLY test if you're under clang.

     

    Also, the full removal of xcode is not even discussed - if you've got a problem with supporting xcode, take it here.

     

    Now, the last part that I really want to air out : why the hell are you removing the -fno-delete-null-pointer-checks parameter?
    That is there for a purpose, namely to allow NP-bugs to be properly debugged and checked.

     

    -fdelete-null-pointer-checks
    Assume that programs cannot safely dereference null pointers, and that no code or data elemet resides there. This enables simple constant folding optimizations at all optimization levels.

    In addition, other optimization passes in GCC use this flag to control global dataflow analyses that eliminate useless checks for null pointers; these assume that if a pointer is checked after it has already been dereferenced, it cannot be null.
    Note however that in some environments this assumption is not true. Use -fno-delete-null-pointer-checks to disable this optimization for programs that depend on that behavior.
    Some targets, especially embedded ones, disable this option at all levels. Otherwise it is enabled at all levels: -O0, -O1, -O2, -O3, -Os. Passes that use the information are enabled independently at different optimization levels.

    Short story: Don't fuck around with the buildsystem unless you know EXPLICITLY how and why things are done the way they are.

    If something is unclear, poke me about it.

     

  8. Compile or cmake problems

    in Help and Support

    Posted

    Confirm the problem on ubuntu and this works to me too https://github.com/f...7adab2a0fe4d22c

    Erm, ok? One note here, since libmpq requires both the libbz2-library and zlib-library objects to already exist before it will do anything...

    The entire linking is controlled by the sequence given in the original file, meaning libmpq will be linked in AFTER the other two has been compiled/linked in, and thus allowing for libMPQ itself to find the requested functions.

    Why this alledgedly happens for you beats me, but for the sake of it, post the parameters you use for make during compilation (that means -j flags and whatnot). I can't see the reason for moving libMPQ -up- in the chain, it kind of counters the entire link-sequence. Unless they changed CMake somewhere and never posted it in their changelogs... :P

    (Also, supply the entire cmake-configuration phase output so I can see where CMake actually grabs the headers from - it might be that it finds something you've installed locally, ie. not systemwide).

  12. "unknown column" "missing table" "duplicate column" error / sql problems / SQLDriverLogFile < answer on 1st post of 1st page

    in Help and Support

    Posted 

    [ERROR]: In mysql_stmt_prepare() id: 30, sql: "SELECT arenaTeamId, weekGames, seasonGames, seasonWins, personalRating FROM arena_team_member WHERE guid = ?"
    
[ERROR]: Unknown column 'personalRating' in 'field list'
    
[ERROR]: In mysql_stmt_prepare() id: 172, sql: "UPDATE arena_team_member SET personalRating = ?, weekGames = ?, weekWins = ?, seasonGames = ?, seasonWins = ? WHERE arenaTeamId = ? AND guid = ?"
    
[ERROR]: Unknown column 'personalRating' in 'field list'
    
[/code]
    
Your database is not up to date.

  19. Compile or cmake problems

    in Help and Support

    Posted

    Hi, the file where it builds this information from is automated through CMake, and is as such something that is my responsibility (at least sorting out issues with the buildsystem itself).

    Please try this, and report back to us regarding this - I dont't have a possibility to test XCode myself, so your help will be appreciated.


    
diff --git a/cmake/compiler/xcode/settings.cmake b/cmake/compiler/xcode/settings.cmake
    
index cd33fc1..ad3c58e 100644
    
--- a/cmake/compiler/xcode/settings.cmake
    
+++ b/cmake/compiler/xcode/settings.cmake
    
@@ -1,2 +1,2 @@
    
 # Set build-directive (used in core to tell which buildtype we used)
    
-add_definitions(-D_BUILD_DIRECTIVE="$(CONFIGURATION)")
    
+add_definitions(-D_BUILD_DIRECTIVE=\\"$(CONFIGURATION)\\")
    
[/code]

  20. The TrinityCore issuetracker and you

    in Guides

    Posted

    Please read and understand the following :

    What we require when you file an issue :

    VERY IMPORTANT, WHY THERE IS NO LATEST: on github after 1 month we can't known the date the issue was posted, and because that we can't known the revision

    Never ever test things with GM accounts

    - Update your core before reporting a bug, the bug of ancient cores can be fixed on newer cores.

    - Add which revision of Trinitycore you're running on (this is the CORE revision, not your client version)

    - Add which database, and what revision, you run on. Remember, you can get the most updated TDB from Downloads · TrinityCore/TrinityCore · GitHub

    - Add a list of which modifications that has been done to the core (if any) if those modifications aren't public available you must share the code if you/we see that they can be reason of bug, if you don't use a clean core and you don't share the code if it afects the bug or the files of the bug (crash) the ticket will be closed.

    - Supply links, spell ids, full spell names, npc ids, npc guids, npc names, gameobject ids, gameobject names detailed, we don't must guess what mob/instance/spell you are talking about.

    addon to help you with ids: http://www.curse.com/addons/wow/spellid#t1:other-downloads get 3.3.5a version.

    Example CORE revision number : b1e2cdb905d6a92edeb505eff968d26c453b252b (LAST is not a valid number), there are 40 Time Zones from UTC−12 to UTC+14, we don't known on what Time Zone you live, for me Today is 31 of July, for someone on Honolulu it's 30 of July.

    Read Howto properly install git on Windows. - Help and Support - TrinityCore if you can't get something like TrinityCore Hash: c4818f189216+ (Win32, Release (little-endian)) (worldserver-daemon) when you use server info on console.

    Example DB revision number : TDB 335.51

    The above is VERY important, so add this when reporting! Any ticket without this info will be closed without notice.

    • Upvote 4
×
×
  • Create New...