Naios
-
Posts
155 -
Joined
-
Last visited
-
Days Won
19
Posts posted by Naios
-
-
Currently TrinityCore is using C++14, the compiler flag for the version is evaluated by CMake with the following CMake CXX target features: https://github.com/TrinityCore/TrinityCore/blob/master/cmake/macros/ConfigureBaseTargets.cmake#L20-L34
-
-
Spec could you try whether applying this patch fixes your issue?
https://gist.github.com/Naios/b1a44d9448fee3fb6031f21a7df94829
-
27 minutes ago, Spec said:
Continuation from IRC
So after moving to VS2017 ive had issues compiling a fresh 3.3.5 build (#7cc074f)
Compile output: https://pastebin.com/fpdt2pJe
I have tried Cmake 3.8.3 - 3.9.6 - 3.10.1 in both x86 and x64, i have tried overwritting the the Zmfactor and i have tried reinstalling every requirement including VS2017.
Probably this is related to 697b4dbef20b5c , I will take a look into this .
-
In order to support C++14 properly the required compiler versions of both branches since b9b667f92 are:
- Visual Studio 2017
- GCC 6.3 (current stable version of Debian 9)
- Clang 3.9 (current stable version of Debian 9 - might work with earlier versions)
-
CMake has a command which allows you to invoke the underlying make programm (nmake, make, ninja...) through
cmake --build YOUR_CMAKE_DIRECTOY --config Release --target YOUR_TARGET
-
If you want to use the automatic script recompiler you must use the INSTALL target. otherwise it won't reinstall changed libraries.
You don't have to do additional stuff when you use the INSTALL target.
- 1
-
-> https://trinitycore.atlassian.net/wiki/display/tc/IRC
Probably you'll receive better help in the IRC.
What's in your TrinityCore directory?
-
AppData isn't a good location for the source and build dir (also because your path contains spaces) -> Move it into the first depth of C:// -> C://TrinityCore and C://TrinityCoreBuild
-
What Nay meant is that you should have left the path empty because it uses the correct path for your machine then.
-
You are probably using an unsupported fork of TC, the current database contains > 1000+ applied world updates (and most of it are already included in the world db). Yours contains 15 as the screenshot shows.
Also I can't imagine how the current codebases could lead to the issues you are describing.
Are you using seperate databases for world/auth/hotfix and char?
-
You can also try to just create the databases manually, the updater will import the base and update sqls then
-
You don't need to downgrade any MSVC version...
Make sure you created the boost environment var which needs to point to your boost root dir. Also make sure you use the CMake x64 generator and the matching x64 dev openssl libraries.
Seems like you mixed x32 and x64.
-
MariaDB 10.1 works very well with TC, but it's not official supported though.
Maybe it's an alternative to MySQL 5.7 for you...
-
1 hour ago, hellomotow said:
and used the base database from trinitycore/sql/base.
Drop your databases and run the worldserver again, the server will create and update every database correctly for you.
-
Maybe you provide more information how you fixed it so other users that encounter the same issue can solve it too.
-
Delete your build directory and re-create it, and follow the "Configuring and generating Visual C++ solutions with CMake" steps in the wiki.
-
Try to re-create your build directory.
-
Could you upload your CMakeCache.txt and revision_data.h please? (You'll find it in your build directory).
-
You need to provide a custom hash function for the `coordinate` type since the compiler doesn't know how you want to hash this custom type:
struct Hasher {
std::size_t operator() (coordinate const& right) const {
return ... ;
}
};std::unordered_set<coordinate, Hasher> ...
For hashing the two ints you could use std::hash and combine it using boost::hash::combine
-
Open an issue at https://github.com/TrinityCore/TrinityCore/issues please, your configuration seems to be right, I guess it's a core issue.
-
Did you try to delete your build directory and recreate it?
-
Coud you attach your revision.h and the CMakeCache.txt which are located in your build directory please?
-
You could write a shell script which creates a list of all files for you.
But using the updates table from another db is the easiest way to go I think.
How to use custom SQL files with the TC update system?
in Help and Support
Posted
Good question. In the time back as I implemented the DB updater I thought about custom updates being compatible to the current database structure.
Currently there is no possibility to prevent such conflicts that you described as part of your question.