Jump to content
TrinityCore

ChazH

Plebs
  • Content Count

    6
  • Joined

  • Last visited

  • Days Won

    1

Everything posted by ChazH

  1. Hello, I have been using TC for a few weeks now and have noticed a few issues. I am using TDB_full_735.00_2018_02_19 and loading the updates from the src folder ( As suggested from the database setup) 1. Cooking window shows 0/0 and will not allow me to update the skills 2. Unable to learn any cooking skills 3. After purchasing the fishing skill, logging out and coming back in. The Skill is removed from my professions and I cannot purchase it again 4. While fishing, the fishing bobber never plays the animation that a fish has landed. Any suggestions on what could be causing these issue? I have been digging around in the code looking into possible ways to fix it but am not sure where to start. I have read the documentation about contributing but still, there is a lot there. Also, is there any write up on how the database is setup or an explanation as to how the tables are structured? I would love to start contributing to this project. Seems like a fun/challenging process. Thank you, Chaz
  2. Hello, I recently just updated to the latest version on master (8.1.5.30706, SHA: 138e822d859fd9ff9d79e1ce16823992ad43aec4) and noticed that my linux build was no longer compiling. The build was failing on a few variables in 'UpdateFields.h' due to the variables being named the same as their struct/class UpdateFields.h : 384 : UpdateFieldArray<QuestLog, 100, 35, 36> QuestLog; UpdateFields.h : 482 : UpdateFieldArray<DynamicUpdateField<Research, -1, -1>, 1, 20, 21> Research; UpdateFields.h : 495 : DynamicUpdateField<SpellPctModByLabel, 0, 17> SpellPctModByLabel; UpdateFields.h : 496 : DynamicUpdateField<SpellFlatModByLabel, 0, 18> SpellFlatModByLabel; UpdateFields.h : 577 : UpdateFieldArray<RestInfo, 2, 461, 462> RestInfo; UpdateFields.h : 586 : UpdateFieldArray<PVPInfo, 6, 551, 552> PvpInfo; It compiles fine in visual studio but fails with gcc. I am not familiar enough with gcc to know if there are any settings that would allow this. However, in the mean time, I was able to get it to compile by providing the namespace for the struct. It works but might not be the best solution or fit with the coding standards. Heres the updates below. UpdateFields.h : 384 : UpdateFieldArray<UF::QuestLog, 100, 35, 36> QuestLog; UpdateFields.h : 482 : UpdateFieldArray<DynamicUpdateField<UF::Research, -1, -1>, 1, 20, 21> Research; UpdateFields.h : 495 : DynamicUpdateField<UF::SpellPctModByLabel, 0, 17> SpellPctModByLabel; UpdateFields.h : 496 : DynamicUpdateField<UF::SpellFlatModByLabel, 0, 18> SpellFlatModByLabel; UpdateFields.h : 577 : UpdateFieldArray<UF::RestInfo, 2, 461, 462> RestInfo; UpdateFields.h : 586 : UpdateFieldArray<UF::PVPInfo, 6, 551, 552> PvpInfo; I was thinking about making a pull request for it but wanted to make sure it was correct first. Also, wasn't sure how the pull request process works in github. Let me know if there are any issues with this or if there is anything that needs to be changed. Thank you, Chaz H
×
×
  • Create New...