Honor System Implementation

[terakoth]

When I try to do a patch for the honor system at https://patch-diff.githubusercontent.com/raw/TrinityCore/TrinityCore/pull/19277.patch I get a problem trying to apply this patch file which is a pull request and it does not load properly, has anyone tried to do this or have this working and if so is there a easier way to add this or am I not applying this right or adding the patch file in the wrong directory. any help on this would be great thanks.

Pull request from https://github.com/TrinityCore/TrinityCore/pull/19277

[CDawg]

Have you tried to contact the author of that patch? I could take a look at it, but I'mnot dabbling too much with 7.x

[codeman3518]

There is no patch file for the honor system at this time or at least I have not seen any, and to really implement this you have to add this manually for now unless you want errors which you get if you do the patch link or cherry picking it into master

[Golrag]

Having the same problem with applying the patch with git apply, so I would suggest you to do the following:

git fetch origin pull/19277/head:honor_patch
git checkout honor_patch

More info:
https://help.github.com/articles/checking-out-pull-requests-locally/

[terakoth]

Okay when I try to git push origin honor_patch I get fatal: remote error: You can't push to git://github.com/TrinityCore/TrinityCore.git Use https://github.com/TrinityCore/TrinityCore.git I try to do that and still get error, is there something else I should be putting to get the patch or honor system implemented with this branch, thanks.

[Golrag]

Well you can't push to TrinityCore/TrinityCore without the right permissions, and pushing isn't necessary when you want to test locally.

Once you have done the 2 commands I gave you, you should just run cmake & compile the server and it's all good for testing

[terakoth]

Thanks, now if I want more then one pull request how can I add more then one in my compile doing them all at once

[CDawg]

On 5/28/2017 at 1:53 AM, terakoth said:

Thanks, now if I want more then one pull request how can I add more then one in my compile doing them all at once

If you have multiple changes, you will want to isolate each PR. If you have multiple changes, it will all already be included at once in one giant PR (without isolating each change).