Jump to content
TrinityCore

Pull Request Implementation


terakoth
 Share

Recommended Posts

As far as I know you have to do it all manual unless I have been doing this work for nothing but anything good you have to do a lot of work to get something great out of it. Just like what you want out of life you only get what you put into life what you get back. Though I do have an application I made that makes this process a lot smoother which takes each file and changes what is in the core over a smooth transition to the commit or request. I will send you the application.

  • Upvote 1
Link to comment
Share on other sites

If you dont mind updating your core in the process with the fork's TC version that the pull request is made for then you can just do git pull <the fork address> <branch name>
If you only want the pull request contents, then you can download it as a diff by appending ".diff" to the end of the pull request URL in github.
Same for patch.
https://github.com/TrinityCore/TrinityCore/pull/19297
https://github.com/TrinityCore/TrinityCore/pull/19297.diff
https://github.com/TrinityCore/TrinityCore/pull/19297.patch
The patch would be the same as doing a cherry-pick in a way I guess if you apply it with git am < file.patch
 

There are many other ways  to go about doing this.
For example you could make a cherry-pick of the commits that are pull requested. (fetch the pull request repository and then do a cherry-pick firstCommitHash^...LastCommitHash)

 

It seems you can also try reference the pull request repository through TC repository as seen here:
https://help.github.com/articles/checking-out-pull-requests-locally/
git fetch origin pull/PRID/head:BRANCHNAME
origin is assumed to be trinitycore repository.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...