Rochet2

Members
  • Content count

    915
  • Joined

  • Last visited

Community Reputation

187 Excellent

2 Followers

About Rochet2

  • Rank
    Snail
  • Birthday 10/26/93

Contact Methods

  • Website URL
    http://rochet2.github.io/
  • Skype
    Rochet22

Profile Information

  • Gender
    Male
  • Location
    Finland

Recent Profile Visitors

6300 profile views
  1. He says that the issue this thread we are in tries to fix cannot be fixed by using the method described if you downloaded the source as a zip. If you are saying that you can still do this fix, then maybe share some steps? The point is not that you cannot get the version of the zip. The point is that you cannot fix the version showing as Trinitycore rev. 1970-01-01 00:00:00 +0000 on startup and in cmake and everywhere.
  2. If you dont mind updating your core in the process with the fork's TC version that the pull request is made for then you can just do git pull <the fork address> <branch name> If you only want the pull request contents, then you can download it as a diff by appending ".diff" to the end of the pull request URL in github. Same for patch. https://github.com/TrinityCore/TrinityCore/pull/19297 https://github.com/TrinityCore/TrinityCore/pull/19297.diff https://github.com/TrinityCore/TrinityCore/pull/19297.patch The patch would be the same as doing a cherry-pick in a way I guess if you apply it with git am < file.patch There are many other ways to go about doing this. For example you could make a cherry-pick of the commits that are pull requested. (fetch the pull request repository and then do a cherry-pick firstCommitHash^...LastCommitHash) It seems you can also try reference the pull request repository through TC repository as seen here: https://help.github.com/articles/checking-out-pull-requests-locally/ git fetch origin pull/PRID/head:BRANCHNAME origin is assumed to be trinitycore repository.
  3. Its enough to just change the DB names in configs (and in DB hurr durr). I use this all the time to hop through the 5 different core/patch combinations I have. http://i.imgur.com/CPIzrMd.png
  4. Hmm, looks like it does tho: master: https://github.com/TrinityCore/TrinityCore/blob/master/src/server/game/Texts/CreatureTextMgr.h#L234 3.3.5; https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Texts/CreatureTextMgr.h#L241 maybe you should post the error message. You probably have not included Player.h or WorldSession.h or something lke that
  5. https://en.wikipedia.org/wiki/Precompiled_header
  6. You probably downloaded them as zip files instead of using git to download it (clone) The installation guide tells you what you should do. https://trinitycore.atlassian.net/wiki/display/tc/Windows+Core+Installation
  7. They were probably moved to rbac as permissions
  8. Follow the TC requirements page guide on how to install visual studio.
  9. Try delete cache folder in wow installation folder. What patch is this on?
  10. Changed windows guides. Another reference is made here though: https://trinitycore.atlassian.net/wiki/display/tc/OS+X+Core+Installation Btw. this reminded me about this from 2013 http://i.imgur.com/AT3akT0.png
  11. Should change release to RelWithDebInfo in the guide? https://trinitycore.atlassian.net/wiki/display/tc/Windows+Core+Installation
  12. Debug builds contain debug code and run a lot slower. Release is optimized more for actual production. Compile your core with release instead of debug to make it run fast.
  13. If you change things in your source folder (D:/Trinity) then you need to run cmake which will alter the files in the build folder, like the sln file. Also as you build the core many files will likely change inside the build folder, like logs and binary files and so on. But you probably dont want to keep track of the changes cmake does to build folder or the changes compiling makes to build folder or bin folder as those are not "your changes"
  14. Not sure how well Visual Studio 2017 is supported yet. Other reasons could be that you did not install your VS with C++. Did you explicitly select that you want to install C++ when you installed VS like the TC requirements page says?
  15. Can you post all the text in this box? Im not sure if read only is an issue. Could be, but the program shouldnt actually edit the files. Make sure D:/Build is not read only as files will be written to it.