Great Name No Game Posted December 3, 2016 Report Share Posted December 3, 2016 I have followed the instructions exactly as to the updating process of commits for my MASTER server, but I have a question that I cant seem to locate the answer to already on the forums. My current commit is running e0fb444. I open GItExt and look for the newer commit, however it is nowhere to be found. Refreshing GitExt brings up.... ... which is currently my current commit. Yet on the website, I am seeing several commits that have been done after my commit (e0fb444). See below. I'm seeing 79b9848 as the most up to date commit. Am I wrong in this presumption? How do I get this commit to show up in my GitExt? Any guidance would be appreciated. Thanks! Link to comment Share on other sites More sharing options...
Rochet2 Posted December 3, 2016 Report Share Posted December 3, 2016 instead of refresh (whatever that does ,, maybe it doesnt do any git commands that change history etc, just refreshes the GUI view), fetch or pull. Fetch gets latest history so you can see the commits (but dont actually have them in your current source) and pull would do fetch and merge (and merging means you would get the stuff(the commits) to your current local repo) I myself dont use any GUI so no idea how git extensions works for example. Im sure many have used or know how the CLI works however so maybe use that instead and then use GUI? Easier to sort these things out in the CLI than in some random GUI - there is just one CLI. Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 3, 2016 Author Report Share Posted December 3, 2016 Thank you. Will give it a shot. Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 3, 2016 Author Report Share Posted December 3, 2016 That worked. After recompiling, Im working on fixing a WorldServer crash issue before I can actually get in game. Link to comment Share on other sites More sharing options...
Nay Posted December 4, 2016 Report Share Posted December 4, 2016 The refresh button in Git Extension only updates the GUI. -- You are missing the VMap files. You can either extract them (recommended) or disable vmaps in worldserver.conf Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 Already extracted and copied from my previous commit folder. For some weird reason or another its still showing the same error. Here's 2 pics of 2 folders. My dir of the WorldServer and the contents of the vmaps folder. @Nay Thanks for your input, can you please advise me further? I'll post screen caps of whatever you need to see. Thanks! - J H Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 It probably doesn't matter, but the BNet server works fine. its only the worldserver.exe that's giving me fits right now. I've redone the entire procedure 3 times and every time it gives me the same result at the same point in the setup. There's got to be something I'm missing. I ran my previous commit on this rig the exact same way. I've double checked the worldserver config file for any discrepancies but since I connect to the localhost, all entries have been set to defaults and I haven't touched anything. Thoughts? Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 Is there any place I need to double/triple check the path for the vmaps? If its default - does that mean just running off the C: dir? Link to comment Share on other sites More sharing options...
Nay Posted December 4, 2016 Report Share Posted December 4, 2016 You can set the DataDir config to an absolute path instead to be sure. https://github.com/TrinityCore/TrinityCore/blob/master/src/server/worldserver/worldserver.conf.dist#L76 For example, I have all the client files in DataDir = "D:/wow/335/data", outside of the build directory. Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 Also - what is the downside to disabling vmaps in the config? Heres what I have currently in my worldserver.conf file. I don't need to edit anything or change anything to make it "Proper" right? Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 3 minutes ago, Nay said: You can set the DataDir config to an absolute path instead to be sure. https://github.com/TrinityCore/TrinityCore/blob/master/src/server/worldserver/worldserver.conf.dist#L76 For example, I have all the client files in DataDir = "D:/wow/335/data", outside of the build directory. I will work on giving that a shot. I find it more organized and meaningful to have frequently access files in an easy-to-remember location as well. Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 No change in behavior. No matter where I move the files to, it cant find the vmaps files even though the vmaps are clearly present in the C:/Trinity/Data folder. (Which is what I entered in the config file.) Link to comment Share on other sites More sharing options...
Rochet2 Posted December 4, 2016 Report Share Posted December 4, 2016 looks correct to me. However, have you tried using forward slashes (/) instead of backslashes (\) ? Link to comment Share on other sites More sharing options...
Aokromes Posted December 4, 2016 Report Share Posted December 4, 2016 very likely he needs to re-extract vmaps and mmaps. Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 @Aokromes - Thats my last resort. You're probably right and I will try that after reversing the slashes as @Rochet2 suggested. Its always a shot. However, if one commit can recognize everything in the vmaps and mmaps, why wouldn't a second? Just a thought. (For the record, I did not delete my previous commit. I wanted to make sure I had everything on hand as a fallback / backout plan. I threw the vmaps and mmaps and everything back into my previous commit and it worked fine.) Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 Changing the direction of the slashes yielded no success. Same results. Will re-extract and test. Link to comment Share on other sites More sharing options...
Rochet2 Posted December 4, 2016 Report Share Posted December 4, 2016 Slightly troubling that it says the file doesnt exist and re extracting would be the solution. If it is, then the error messages probably need a bit of a tweak or something. Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 I agree. @Rochet2 What also baffles me is that it will work if moved to a previous commit but not work in a newer one. I just logged off retail and am now going to try this all again. I'll update momentarily. -J Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 Frig.......Extracted fresh vmaps and nothing different. Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 So....whats the difference between disabling vmaps and having them enabled? Link to comment Share on other sites More sharing options...
Rochet2 Posted December 4, 2016 Report Share Posted December 4, 2016 If vmaps are not enabled then creatures go through ground a lot and so. For example at booty bay dock the NPCs cant seem to be able to stay on the dock platform and drop to water. Guessing: Its like many things in the game wouldnt exist for them, because they dont. Map files only have limited amount of info and they dont proabably contain all the specific info about each object on a map, but just possibly the main terrain (no trees, no barrels etc) that is where vmaps come into play. VMaps: VMaps are optional, but highly recommended. VMaps ("Virtual Maps") calculate the possibility of line-of-sight, as an example. Based on their content, the server can (for example) calculate if spell casts are possible (e.g. if a wall is in between the target and caster or not). Quote from https://trinitycore.atlassian.net/wiki/display/tc/Help%3A+FAQ Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 Right. This should be interesting. WorldServer started after vmaps were turned off. Here goes nothing. Link to comment Share on other sites More sharing options...
Great Name No Game Posted December 4, 2016 Author Report Share Posted December 4, 2016 Upon login.... This just keeps getting better and better! Link to comment Share on other sites More sharing options...
Rochet2 Posted December 4, 2016 Report Share Posted December 4, 2016 what is your client version and your core commit? As you probably use master branch, TC is not always on the latest blizz patch. So depending on that you need to wait until TC gets to a version you have or that you can download. check the thread in news and announcements for the supported version. I also recommend checking the git commit history because it can be that the supported version changes before updated to the thread or you have an older than newest commit which can support some older version. 1 Link to comment Share on other sites More sharing options...
Aokromes Posted December 4, 2016 Report Share Posted December 4, 2016 [00:49:49] <WardenX> TrinityCore/TrinityCore (f2277dd * master): Shauren committed Core: Change allowed build to 7.1.0.23171 https://github.com/TrinityCore/TrinityCore/commit/f2277dd6de7ea29fa47e226ca2084e1eaeb2559b also, since yesterday vmaps and mmaps needs to be updated. Link to comment Share on other sites More sharing options...
Recommended Posts